Update View Component metric building #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
test/multiverse/suites/view_component/view_component_instrumentation_test.rb
Show resolved
Hide resolved
fallwith
previously approved these changes
Oct 10, 2024
kaylareopelle
previously approved these changes
Oct 10, 2024
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
hannahramadan
dismissed stale reviews from kaylareopelle and fallwith
via
1154102
tannalynn
previously approved these changes
Oct 11, 2024
tannalynn
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Component removed private method
.identifierin v3.16.0, which is how the library used to identify components for instrumentation, and is what our was based off of as well. View Component now usessource_location. This PR updates our instrumentation to do the same and adds error handling in the case that the methods we rely on to build metric names are changed.source_locationis a confirmed compatible call with the earliest version of View Component available on RubyGems, v1.16.0.closes #2874